Yeah, it's a well-kept secret unfortunately.
Rough skimming code review:
1. bool is your friend, int is for old people :(
2. You should use ccan/ directly not in pieces: easier to update.
3. Your cursor API makes me cry, can I rewrite it? It's going to hurt somebody.
4. Do you want neatening pull requests?
Rusty Russell
npub179…elz4s
2024-08-17 03:04:00 UTC
in reply to nevent1q…mdg2
Author Public Key
npub179e9tp4yqtqx4myp35283fz64gxuzmr6n3yxnktux5pnd5t03eps0elz4sPublished at
2024-08-17 03:04:00 UTCEvent JSON
{
"id": "05e9148552ee19dd5fb950bb64649dfef392b0f7cab278754a1354a6fff5017b",
"pubkey": "f1725586a402c06aec818d1478a45aaa0dc16c7a9c4869d97c350336d16f8e43",
"created_at": 1723863840,
"kind": 1,
"tags": [
[
"e",
"2747971a204800ee61ed868ccf281a3347d10b84336ff89ac19819a013489cb8",
"",
"root"
],
[
"e",
"a8424c989aff7fe3612766fccb86e64370bec5333e275d8dad8e863c9d7e594b"
],
[
"e",
"f1ae8024148e3251510b0d960cba124f3163f6aea1df60683c1ff0946b9bc545",
"",
"reply"
],
[
"p",
"f1725586a402c06aec818d1478a45aaa0dc16c7a9c4869d97c350336d16f8e43"
],
[
"p",
"32e1827635450ebb3c5a7d12c1f8e7b2b514439ac10a67eef3d9fd9c5c68e245"
]
],
"content": "Yeah, it's a well-kept secret unfortunately. \n\nRough skimming code review: \n1. bool is your friend, int is for old people :(\n2. You should use ccan/ directly not in pieces: easier to update. \n3. Your cursor API makes me cry, can I rewrite it? It's going to hurt somebody. \n4. Do you want neatening pull requests?",
"sig": "690ba3ad8b7cccc2063d00d0363831a8b17914088d19ca7ecbb7c9004ddf24f5e72755441ae3e2fb8f4840c03eac6b83b779628180f226a6e8098450c34b8e2a"
}