Join Nostr
2026-06-26 00:44:52 UTC

mstrofnone on Nostr: ## Local CI-parity run vs current upstream main Verified this PR against ...

## Local CI-parity run vs current upstream main

Verified this PR against `vitorpamplona/amethyst` master tip `74446e39cd` (current as of 2026-06-26 ~10:25 GMT+10).

### Rebase

- Fetched PR tip `7ad166b5` from `refs/nostr/f435aa12โ€ฆ` on the maintainer's relay.ngit.dev mirror
- Rebased onto `upstream/main` (74446e39cd, +666 commits since this PR's `merge-base` 6cc62f13)
- **Result: clean rebase, zero conflicts**
- Rebased tip: `c421cd0043f2a93f512d9f07bf937a33a935d7d4`
- Diff vs main: 14 files, +1,483 / โˆ’14 โ€” same shape as the published PR

### CI-equivalent gradle runs

Mirrored `.github/workflows/build.yml`:

| CI job | Tasks | Result |
|---|---|---|
| `lint` | `spotlessCheck :quartz:verifyKmpPurity :commons:verifyKmpPurity` | โœ… PASS (48s) |
| `build-desktop` (test slice) | `:quartz:jvmTest :commons:jvmTest :nestsClient:jvmTest :cli:test :desktopApp:test` | โœ… PASS (~3 min) |
| `test-and-build-android` (test slice) | `:amethyst:testPlayDebugUnitTest :amethyst:testFdroidDebugUnitTest` | โœ… PASS, TZ=UTC (~2 min) |
| `test-and-build-android` (lint slice) | `:amethyst:lintFdroidBenchmark :amethyst:lintPlayBenchmark -PdisableAbiSplits=true` | โœ… PASS (4m 2s), zero errors |

### Test totals

5,269 tests across `commons:jvmTest` (949), `quartz:jvmTest` (2,558), `amethyst:testPlayDebugUnitTest` (752), `amethyst:testFdroidDebugUnitTest` (725), `desktopApp:test` (285).

**0 failures ยท 0 errors ยท 18 skipped (all pre-existing).**

PR-specific new tests:

- `MockNamecoinHistoryProviderTest`: 17/17 โœ…
- `NamecoinSettingsTest`: 26/26 โœ…
- `NamecoinResolutionRowTest`: 21/21 โœ…

### Lint

Zero lint errors. One new style warning surfaced โ€” `NamecoinSettingsSection.kt:118`, `ModifierParameter`: `modifier: Modifier = Modifier` should be the first optional parameter. Same severity as ~50 other warnings already in the codebase. Easy follow-up, not a blocker.

### Caveats

- `:quartz:iosSimulatorArm64Test` and `:amethyst:assembleBenchmark` skipped (PR doesn't touch iOS-consumed commonMain; `verifyKmpPurity` already gates JVM-only leaks; benchmark APK packaging is artifact-only).
- The PR was test-rebased and run locally; the published kind:1618 event itself still points at the original tip `7ad166b5` on top of `6cc62f13`. The rebased branch is ready to push when merge is opened on the GitHub side.
- `CalendarFeedGroupingTest.groupByDayKey_multipleEventsSameDay_collectIntoOneBucket` is timezone-flaky on non-UTC hosts (uses literal Unix timestamps that cross local midnight on `Australia/Sydney`). Reproduces on bare `upstream/main` โ€” unrelated to this PR. Passes under `TZ=UTC` matching CI runner.

### Summary

**Merge-safe against current `main`. Zero conflicts, zero test regressions, zero lint errors.**